Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry Updates September 2023, Part 2: cspell fixes coming #3292

Merged
merged 7 commits into from
Sep 19, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Sep 19, 2023

This PR includes multiple changes towards the registry:

  • most changes are for including cspell:ignore in files where it is needed, this will allow us to enable spell checking on the registry
  • remove the go components (like Remove deprecated Go instrumentation libraries #3291)
  • remove other deprecated components (jaeger exporters)
  • add new components

@svrnm svrnm requested a review from a team September 19, 2023 15:18
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the "remove the Go components"

@svrnm
Copy link
Member Author

svrnm commented Sep 19, 2023

Approving the "remove the Go components"

thanks, I also included you as author in b64967e, that way you will be also co author of the squashed commit when merged

@svrnm svrnm requested review from a team September 19, 2023 15:52
@svrnm
Copy link
Member Author

svrnm commented Sep 19, 2023

@open-telemetry/java-approvers , @open-telemetry/python-approvers @open-telemetry/php-approvers this PR introduces some additional terms in cspell/textlint and requires some updates towards cspell ignore lists within your respective docs. See commit 9d4fbd9 for details

@svrnm svrnm merged commit 346da90 into open-telemetry:main Sep 19, 2023
@svrnm svrnm deleted the registry-updates-sept23-2 branch September 19, 2023 18:18
svrnm added a commit that referenced this pull request Oct 16, 2023
#3292 allows us to also apply cspell checks on the registry files.

See #3376 for newly introduced cspell issues.
@svrnm svrnm mentioned this pull request Oct 16, 2023
chalin pushed a commit that referenced this pull request Oct 16, 2023
#3292 allows us to also apply cspell checks on the registry files.

See #3376 for newly introduced cspell issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants