CI: check external links (excluding GH) #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
force-pushed
the
chalin-im-ext-link-checking-take-1-2023-02-18
branch
2 times, most recently
from
99eca67
to
9c1aaad
Compare
|
Links checked (internal and external) in less than 8 seconds. From the build log: > npm run _check:links
...
htmltest started at 08:10:56 on public
--
| ========================================================================
| ✔✔✔ passed in 7.515506054s
| tested 333 documents |
chalin
commented
Feb 18, 2023
| implemented OpenTelemetry in their organizations, resolved common issues, and | ||
| more. Example topics that have been discussed include tail sampling, collector | ||
| scaling, and OpAMP; there really is no limit to the topics! We simply ask that | ||
| you be respectful and abide by the [Chatham House Rule](https://www.chathamhouse.org/about-us/chatham-house-rule#:~:text=The%20Rule%20reads%20as%20follows,other%20participant%2C%20may%20be%20revealed.). |
There was a problem hiding this comment.
FYI, I dropped the higlight "hash" from the link.
There was a problem hiding this comment.
Probably best to review the changes to this file while ignoring whitespace differences.
|
/cc @trask |
chalin
force-pushed
the
chalin-im-ext-link-checking-take-1-2023-02-18
branch
from
9c1aaad
to
35bfff1
Compare
cartermp
approved these changes
Feb 19, 2023
This was referenced Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Adding external link checking, with the cache, takes at most 2 sec more on my local machine.
check:linksNPM script for full link checkingstaticrefcache.jsonfile understaticso that it gets deployed. That way each "edition" of the website will have it's own published refcache data file.Note: If / once this PR is merged, anyone submitting a PR will need to run
npm run test(as indicated in the contributing notes) to update the refcache. We're not currently filing if that isn't done, but we might soon./cc @reyang