Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix x509 error about vendor link #2350

Closed
wants to merge 1 commit into from
Closed

Fix x509 error about vendor link #2350

wants to merge 1 commit into from

Conversation

windsonsea
Copy link
Member

Hi @chalin , as you suggested in #2128, the https certificate was updated months ago.

Now change the url to Insight that is an observability product and integrates with many OTel features.

image

@windsonsea windsonsea requested a review from a team February 16, 2023 03:01
chalin
chalin requested changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still see an invalid certificate (notice the expiry date):

image

content/en/ecosystem/vendors.md Outdated
| DaoCloud | Yes | Yes | [docs.daocloud.io/...](https://docs.daocloud.io/en/insight/06UserGuide/01quickstart/otel/otel/) |
| DaoCloud | Yes | Yes | [docs.daocloud.io/...](https://docs.daocloud.io/en/insight/03ProductBrief/WhatisInsight/) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @cartermp mentioned elsewhere, we prefer links into the OTel docs, so the original link was better.

@windsonsea
Copy link
Member Author

ok, well noted. I'm asking IT staff why. This PR can be closed because nothing need to be changed currently.

The certificate looks different in and out of China -_!

image

@windsonsea windsonsea closed this Feb 16, 2023
@chalin
Copy link
Contributor

chalin commented Feb 16, 2023

The certificate looks different in and out of China -_!

That is what I was beginning to suspect.

@windsonsea
Copy link
Member Author

Finally, the SSL certificate works now. It is effective after 24:00 last night while it was updated 8 hours ago.

image

Verified it at: https://www.sslchecker.com/sslchecker

@windsonsea windsonsea deleted the vendory branch February 19, 2023 13:02
@chalin
Copy link
Contributor

chalin commented Feb 19, 2023

Thanks for the confirmation. I've removed the link-checker ignore rule for daocloud.io in #2362, see https://github.com/open-telemetry/opentelemetry.io/pull/2362/files#diff-9ad64044531d7d8c033064f11141586478b535147312374c24f8d2d997722889L19-L20.

@jewel0405 jewel0405 mentioned this pull request Aug 27, 2023
Open
@jewel0405 jewel0405 mentioned this pull request Feb 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@windsonsea @chalin