Add basic .NET Automatic Instrumentation doc page #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Sep 13, 2022
cartermp
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Looks good. Has there been progress on better clarifying what .NET autoinstrumentation is? In other languages there's an agent you deploy and run with the app, and while that's not what it is for .NET, it's similar enough in function that this is already a term being used elsewhere.
I don't think this needs to be clarified in the PR, but it will need to be clarified sooner or later.
cijothomas
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #972
Follow-up after:
Solves open-telemetry/opentelemetry-dotnet-instrumentation#999
This PR creates a very simple page. However, it can be further enhanced in the next PRs.
Preview: https://deploy-preview-1740--opentelemetry.netlify.app/docs/instrumentation/net/automatic/
PTAL @open-telemetry/dotnet-maintainers @open-telemetry/dotnet-instrumentation-maintainers @theletterf