-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify "automatic instrumentation" term #2700
Conversation
PTAL @open-telemetry/instr-wg @open-telemetry/java-instrumentation-approvers @open-telemetry/dotnet-instrumentation-approvers |
I don't think we should be removing reference to OTEL APIs, on the contrary, we should be emphasizing it, but clarifying. Specifically, an auto-instrumentation that attaches to the code at runtime and somehow exports OTEL-compatible data, would NOT be a compliant auto-instrumentation in my view, because:
|
@yurishkuro How about adding:
? Any better proposal? However, I am not sure if this kind of detail should be contained in the glossary. Maybe there should be a dedicated document/spec describing automatic instrumentation (it rather should not be part of this PR). |
I will be AFK for a month. If there will be any blocking feedback then I am OK if someone addresses it on my branch. I allowed edits and access to secrets by maintainers. Of course, this PR can also be closed and someone can open a new one. But maybe it is already good enough to be merged 🤞 |
Fixes #2336
Relates to open-telemetry/opentelemetry-dotnet-instrumentation#958
Relates to open-telemetry/opentelemetry.io#1565
Changes
Clarify "automatic instrumentation" term by removing some fragments that can bring confusion.