Added resource detection spec #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
Aug 15, 2020
james-bebbington
force-pushed
the
resource-detection
branch
from
0fa6a1d
to
c5429e4
Compare
james-bebbington
force-pushed
the
resource-detection
branch
from
c5429e4
to
039601f
Compare
|
Overall good @james-bebbington ! Good start, looks good to me! @open-telemetry/specs-approvers please review - this is based on an approved OTEP, so hopefully we should be able to get this in soon. |
tigrannajaryan
added
the
spec:resource
|
/cc @markwolff |
carlosalberto
approved these changes
Aug 19, 2020
|
Hey @james-bebbington please update this PR so we can get it moving. Approving it meanwhile. |
markwolff
approved these changes
Aug 19, 2020
carlosalberto
approved these changes
Aug 20, 2020
|
Thanks @james-bebbington ! Looks great! @tigrannajaryan Please re-review when you have some free cycles. |
tigrannajaryan
approved these changes
Aug 20, 2020
bogdandrutu
approved these changes
Aug 20, 2020
aabmass
approved these changes
Aug 21, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds specs for how resource detection should be implemented. Also adds specs for default detection of resource information from the
OTEL_RESOURCE_ATTRIBUTESenvironment variable.Related issues:
#535
Related oteps:
open-telemetry/oteps#111