Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource initialization from environment variable #535

Closed
mwear opened this issue Mar 30, 2020 · 7 comments
Closed

Resource initialization from environment variable #535

mwear opened this issue Mar 30, 2020 · 7 comments
Assignees
@james-bebbington
Labels
priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:resource Related to the specification/resource directory

Comments

@mwear
Copy link
Member

mwear commented Mar 30, 2020

In the JS SIG we are adding the ability to create a Resource with labels specified by environment variable. This was a feature in OpenCensus, but it is currently unspecified for OpenTelemetry.

While porting this functionality over, we have kept the same value format, but changed the environment variable name from OC_RESOURCE_LABELS to OTEL_RESOURCE_LABELS.

I'm opening this issue as a point of discussion so that we can standardize this behavior between projects.
@mwear mwear mentioned this issue Mar 30, 2020
Merged
@jkwatson
Copy link
Contributor

In the Java repo, we converted it to OTEL_RESOURCE_ATTRIBUTES, so yes, some consistency would be great. :)

@dyladan
Copy link
Member

dyladan commented Mar 30, 2020

Consistency not just in the name but in behavior would be nice.

@Oberon00
Copy link
Member

Related: #505.

This was referenced Apr 21, 2020
Closed
Closed
@james-bebbington james-bebbington mentioned this issue Jun 3, 2020
Merged
@bogdandrutu bogdandrutu added the spec:resource Related to the specification/resource directory label Jun 12, 2020
@carlosalberto carlosalberto added the release:required-for-ga Must be resolved before GA release, or nice to have before GA label Jul 10, 2020
@bogdandrutu bogdandrutu added the priority:p1 Highest priority level label Jul 24, 2020
@andrewhsu
Copy link
Member

from the spec sig mtg today, talked about this and assigned to @james-bebbington . will this be part of the oteps-111 work?

@james-bebbington
Copy link
Member

from the spec sig mtg today, talked about this and assigned to @james-bebbington . will this be part of the oteps-111 work?

Yes it should be. I will write up a spec for this shortly

@james-bebbington james-bebbington mentioned this issue Aug 15, 2020
Merged
@tedsuo
Copy link
Contributor

tedsuo commented Sep 10, 2020

This issue appears to be addressed. @james-bebbington @mwear can we close it?

@mwear
Copy link
Member Author

mwear commented Sep 14, 2020

This was addressed in #811. We've standardized on OTEL_RESOURCE_ATTRIBUTES. I'll close this.

@mwear mwear closed this as completed Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@james-bebbington james-bebbington

Labels
priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:resource Related to the specification/resource directory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@tedsuo @andrewhsu @carlosalberto @james-bebbington @Oberon00 @jkwatson @bogdandrutu @dyladan @mwear