Specify how probability sampler is used with ParentOrElse #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
force-pushed
the
probability-sampler-parent
branch
from
3ea934d to
d985de9
Compare
arminru
approved these changes
Jul 15, 2020
carlosalberto
approved these changes
Jul 15, 2020
carlosalberto
added
area:sampling
Oberon00
approved these changes
Jul 15, 2020
specification/trace/sdk.md
Outdated
| * The default behavior is to apply the sampling probability only for Spans | ||
| that are root spans (no parent) and Spans with remote parent. However there | ||
| should be configuration to change this to "root spans only", or "all spans". | ||
| * The probability sampler should ignore the parent `SampledFlag`. |
There was a problem hiding this comment.
Note that in Java, the probability sampler also checks parent links' sampled flag. Should we explicitly call out somewhere how to deal with links in combination with sampling? Probably out of scope for this PR though. See https://github.com/open-telemetry/opentelemetry-java/blob/v0.6.0/sdk/src/main/java/io/opentelemetry/sdk/trace/Samplers.java#L234
There was a problem hiding this comment.
Oh, good point. It sounds 'big' enough to be done in its own issue/PR.
yurishkuro
reviewed
Jul 15, 2020
yurishkuro
approved these changes
Jul 15, 2020
bogdandrutu
approved these changes
Jul 15, 2020
|
needs a rebase |
dyladan
force-pushed
the
probability-sampler-parent
branch
from
b199cc3 to
39433c9
Compare
codeboten
pushed a commit
to codeboten/opentelemetry-specification
that referenced
this pull request
Jul 20, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
Probabilitysampler specification still specifies parent handling, but that it is superseded by the existence of theParentOrElsesampler. This change makes it clear that parent handling should be done byParentOrElsesampler and thatProbabilitysampler does only probability.