Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open-telemetry/opentelemetry-specification#704 simplified the probability sampler, relying on
parent_or_else
to respect the parent context's sampled flag, if required. This PR updates the probability sampler accordingly.#321 highlighted that actually setting the sampler to something other than the default is cumbersome. There are 2 levels of complexity here:
This also fixes 2. above by adding a few helpers for the common cases of
parent_or_else
delegating to one of the standard samplers. E.g.becomes: