Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for empty values in Logs Data Model #3853

Merged
merged 24 commits into from
Mar 8, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
eb2fea5
Define handling of empty keys and values in Logs Data Model
pellared Jan 31, 2024
5102cf5
Update changelog
pellared Jan 31, 2024
059fb64
Clarify empty keys
pellared Jan 31, 2024
985a1de
Update CHANGELOG.md
pellared Jan 31, 2024
1c5f1fb
Revert requirement that key cannot be empty
pellared Jan 31, 2024
b44c1a4
Merge branch 'main' into logs-empty
pellared Jan 31, 2024
85a80f3
Merge branch 'main' into logs-empty
pellared Feb 1, 2024
f5644fb
Merge branch 'main' into logs-empty
pellared Feb 6, 2024
49abb7a
Merge branch 'main' into logs-empty
pellared Feb 6, 2024
189d47a
Merge branch 'main' into logs-empty
pellared Feb 7, 2024
d67e9d9
Merge branch 'main' into logs-empty
pellared Feb 13, 2024
78035fb
Update specification/logs/data-model.md
pellared Feb 15, 2024
d6664ae
Update data-model.md
pellared Feb 19, 2024
695c219
Merge branch 'main' into logs-empty
pellared Feb 19, 2024
2623dcf
Update CHANGELOG.md
pellared Feb 19, 2024
d4700cf
Update data-model.md
pellared Feb 20, 2024
01dbe8c
Merge branch 'main' into logs-empty
pellared Feb 20, 2024
92490c2
Merge branch 'main' into logs-empty
pellared Feb 23, 2024
8f124ef
Merge branch 'main' into logs-empty
pellared Feb 26, 2024
81d5937
Merge branch 'main' into logs-empty
pellared Feb 27, 2024
07db469
Merge branch 'main' into logs-empty
arminru Feb 27, 2024
ffe6ac3
Merge branch 'main' into logs-empty
pellared Feb 28, 2024
260fdce
Merge branch 'main' into logs-empty
pellared Mar 5, 2024
264d903
Merge branch 'main' into logs-empty
pellared Mar 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ release.

- Fix `Resource` field type in Logs Data Model.
([#3826](https://github.com/open-telemetry/opentelemetry-specification/pull/3826))
- Define handling of empty keys and values.
([#3853](https://github.com/open-telemetry/opentelemetry-specification/pull/3853))

### Resource

Expand Down
8 changes: 5 additions & 3 deletions specification/logs/data-model.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,15 @@ Value of type `any` can be one of the following:

- An array (a list) of `any` values,

- A `map<string, any>`.
- A `map<string, any>`,

- An empty value (e.g. `null`).
jack-berg marked this conversation as resolved.
Show resolved Hide resolved
pellared marked this conversation as resolved.
Show resolved Hide resolved

#### Type `map<string, any>`

Value of type `map<string, any>` is a map of string keys to `any` values. The
keys in the map are unique (duplicate keys are not allowed). The representation
of the map is language-dependent.
keys in the map are non-`null`, non-empty, unique (duplicate keys are not allowed).
pellared marked this conversation as resolved.
Show resolved Hide resolved
The representation of the map is language-dependent.

Arbitrary deep nesting of values for arrays and maps is allowed (essentially
allows to represent an equivalent of a JSON object).
Expand Down
Loading