Add support for empty values in Logs Data Model #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
reviewed
Jan 31, 2024
pellared
changed the title
MrAlias
approved these changes
Jan 31, 2024
jack-berg
reviewed
Feb 13, 2024
5 tasks
|
@jack-berg @tigrannajaryan I updated the PR. PTAL |
|
I believe this should be treated as a backward compatible change because:
Does anyone think this is an incorrect interpretation of our compatibility rules? |
tigrannajaryan
approved these changes
Feb 23, 2024
trask
approved these changes
Feb 27, 2024
jack-berg
approved these changes
Feb 29, 2024
Merged
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Fixes open-telemetry#3835 ## Changes - Define empty value as an acceptable type for `any` I think that adding support for additional type is not a breaking change. I also think that users may also want to preserve the empty values that are in structured data (e.g. record body and attributes) that they emit in their applications. E.g. `slog` a structured logging package which is part of Go standard library accepts `nil` (null, empty value) as a valid attribute value. The Bridge API should do its best to carry over as much logging data as possible until it is can be passed via OTLP . See: https://go.dev/play/p/KN5Wea6h_f-
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3835
Changes
anyI think that adding support for additional type is not a breaking change. I also think that users may also want to preserve the empty values that are in structured data (e.g. record body and attributes) that they emit in their applications.
E.g.
sloga structured logging package which is part of Go standard library acceptsnil(null, empty value) as a valid attribute value. The Bridge API should do its best to carry over as much logging data as possible until it is can be passed via OTLP . See: https://go.dev/play/p/KN5Wea6h_f-