-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix discrepancy between status names #385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current names are better, as InternalError
and UnknownError
are indeed meant to indicate an internal resp. unknown error and not any arbitrary unknown (or internal?) status.
For clarity - the issue is that our names slightly diverge from gRPC status codes, correct? In gRPC, these codes are called gRPC codes: https://github.com/grpc/grpc/blob/master/doc/statuscodes.md @arminru I do agree that @bogdandrutu as our resident gRPC expert, how much does this bikeshed matter to you? :) |
In either case we should avoid using status code names that are nearly identical to gRPC's. I can imagine semantically-identical but differently-named status codes causing problems for people using both gRPC and OT, and that distinction being more confusing than whether these codes are named |
Fixes open-telemetry#384 Co-authored-by: Sergey Kanzhelev <[email protected]> Co-authored-by: Bogdan Drutu <[email protected]>
Fixes open-telemetry#384 Co-authored-by: Sergey Kanzhelev <[email protected]> Co-authored-by: Bogdan Drutu <[email protected]>
Fixes #384