Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discrepancy between status names #385

Merged
merged 3 commits into from
Dec 25, 2019

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Dec 12, 2019

Fixes #384

Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current names are better, as InternalError and UnknownError are indeed meant to indicate an internal resp. unknown error and not any arbitrary unknown (or internal?) status.

@tedsuo
Copy link
Contributor

tedsuo commented Dec 18, 2019

For clarity - the issue is that our names slightly diverge from gRPC status codes, correct? In gRPC, these codes are called UKNOWN and INTERNAL.

gRPC codes: https://github.com/grpc/grpc/blob/master/doc/statuscodes.md

@arminru I do agree that UnknownError and InternalError are clearer.

@bogdandrutu as our resident gRPC expert, how much does this bikeshed matter to you? :)

@c24t
Copy link
Member

c24t commented Dec 18, 2019

In either case we should avoid using status code names that are nearly identical to gRPC's. I can imagine semantically-identical but differently-named status codes causing problems for people using both gRPC and OT, and that distinction being more confusing than whether these codes are named *Error.

@bogdandrutu bogdandrutu merged commit ccbf363 into open-telemetry:master Dec 25, 2019
@ocelotl ocelotl deleted the issue_384 branch January 7, 2020 19:17
SergeyKanzhelev added a commit to SergeyKanzhelev/opentelemetry-specification that referenced this pull request Feb 18, 2020
Fixes open-telemetry#384

Co-authored-by: Sergey Kanzhelev <[email protected]>
Co-authored-by: Bogdan Drutu <[email protected]>
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancy between status names
7 participants