Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canonical status code "Unknown" should be named "UnknownError" #314

Closed
Oberon00 opened this issue Dec 3, 2019 · 2 comments
Closed

Canonical status code "Unknown" should be named "UnknownError" #314

Oberon00 opened this issue Dec 3, 2019 · 2 comments
Labels
api Affects the API package. bug Something isn't working tracing

Comments

@Oberon00
Copy link
Member

Oberon00 commented Dec 3, 2019

Spec: https://github.com/open-telemetry/opentelemetry-specification/blob/e6cd52d034c981ca4fcf896ccd7464e783589c0f/specification/api-tracing.md#statuscanonicalcode
@Oberon00 Oberon00 added bug Something isn't working api Affects the API package. tracing labels Dec 3, 2019
@ocelotl
Copy link
Contributor

ocelotl commented Dec 12, 2019

May be fixed by this.

@ocelotl
Copy link
Contributor

ocelotl commented Jan 7, 2020

I am closing this issue since this has been merged in the specification.

@ocelotl ocelotl closed this as completed Jan 7, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@OlivierAlbertini @mayurkale22
fix: change options to config based on BasePlugin (open-telemetry#314)
013a1e4 
closes open-telemetry#313

Signed-off-by: Olivier Albertini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Affects the API package. bug Something isn't working tracing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Oberon00 @ocelotl