Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit view-rename capabilities in the presence of multi-select views #2168

Merged
merged 10 commits into from
Dec 10, 2021
+6 −0
Merged

Limit view-rename capabilities in the presence of multi-select views #2168

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
75c56ae
Limit view-rename capabilities in the presence of multi-select of ins…
jsuereth Nov 24, 2021
6972f67
Fixes from review.
jsuereth Nov 24, 2021
141759c
Merge remote-tracking branch 'origin/main' into wip-limit-view-config
jsuereth Dec 3, 2021
1b3adf3
Fixes from reivew.
jsuereth Dec 3, 2021
82d637f
Update specification/metrics/sdk.md
jmacd Dec 10, 2021
a4519a4
Update specification/metrics/sdk.md
jmacd Dec 10, 2021
e7e472e
Update specification/metrics/sdk.md
jmacd Dec 10, 2021
87a06d6
Merge branch 'main' into wip-limit-view-config
jmacd Dec 10, 2021
204c9e9
Merge branch 'main' into wip-limit-view-config
jsuereth Dec 10, 2021
396a37e
Merge branch 'main' into wip-limit-view-config
jmacd Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,15 @@ are the inputs:
This should be a factory or callback similar to aggregation which allows
different reservoirs to be chosen by the aggregation.

The SDK MUST not allow the following configurations to be used together:
jmacd marked this conversation as resolved.
Show resolved Hide resolved

- An instrument selection criteria lacking instrument type and instrument name
criteria combined with a specified `name` for the View. This leads to
gauranteed view conflicts between instruments.
- An instrument selection criteria with wildcard name support and no specified
instrument type and a specified `name` for the View. This leads to gauranteed
jmacd marked this conversation as resolved.
Show resolved Hide resolved
view conflicts between instruments.
jmacd marked this conversation as resolved.
Show resolved Hide resolved

jmacd marked this conversation as resolved.
Show resolved Hide resolved
The SDK SHOULD use the following logic to determine how to process Measurements
made with an Instrument:

Expand All @@ -196,6 +205,8 @@ made with an Instrument:
default behavior off.
* END.


jsuereth marked this conversation as resolved.
Show resolved Hide resolved

Here are some examples:

```python
Expand Down