Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit view-rename capabilities in the presence of multi-select views #2168

Merged
merged 10 commits into from
Dec 10, 2021
Merged

Limit view-rename capabilities in the presence of multi-select views #2168

merged 10 commits into from
Dec 10, 2021

Conversation

jsuereth
Copy link
Contributor

Fixes #2141

  • Remove the ability to force multiple-instrument metric streams to the same name.

@jsuereth jsuereth requested review from a team November 24, 2021 16:34
@reyang reyang added area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Nov 25, 2021
@reyang reyang added this to the Metrics API/SDK Stable Release milestone Nov 29, 2021
@jsuereth
Copy link
Contributor Author

jsuereth commented Dec 3, 2021

@cijothomas / @jack-berg - I retweaked the wording here.

Cijo - I reworded this to make sure it's understood it applies to view registration where criteria is provided apriori (not the callback approach, which I think falls outside this specification).

Jack - Retweaked the wording you provided with the limitation we feel like we need in the spec right now.

aabmass
aabmass approved these changes Dec 7, 2021
View reviewed changes
specification/metrics/sdk.md Outdated Show resolved Hide resolved
jmacd
jmacd approved these changes Dec 10, 2021
View reviewed changes
specification/metrics/sdk.md Outdated Show resolved Hide resolved
jmacd
jmacd reviewed Dec 10, 2021
View reviewed changes
specification/metrics/sdk.md Outdated Show resolved Hide resolved
@jmacd jmacd enabled auto-merge (squash) December 10, 2021 21:39
@jmacd jmacd merged commit 42fa8f6 into open-telemetry:main Dec 10, 2021
@jsuereth jsuereth deleted the wip-limit-view-config branch December 13, 2021 13:47
@cijothomas cijothomas mentioned this pull request Dec 15, 2021
Closed
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@jsuereth @jmacd @aabmass
Limit view-rename capabilities in the presence of multi-select views (o…
e7c5f25 
…pen-telemetry#2168)

* Limit view-rename capabilities in the presence of multi-select of instruments.

* Fixes from review.

* Fixes from reivew.

* Update specification/metrics/sdk.md

Co-authored-by: Aaron Abbott <[email protected]>

* Update specification/metrics/sdk.md

* Update specification/metrics/sdk.md

Co-authored-by: Joshua MacDonald <[email protected]>
Co-authored-by: Aaron Abbott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang left review comments

@jmacd jmacd jmacd approved these changes

@jack-berg jack-berg jack-berg approved these changes

@MrAlias MrAlias MrAlias approved these changes

@cijothomas cijothomas cijothomas approved these changes

@aabmass aabmass aabmass approved these changes

Assignees

@tigrannajaryan tigrannajaryan

Labels
area:sdk Related to the SDK release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
Metrics API/SDK Stable Release
Development

Successfully merging this pull request may close these issues.

Clarify what happens if a View matches with multiple instruments
8 participants
@jsuereth @aabmass @jmacd @cijothomas @MrAlias @reyang @jack-berg @tigrannajaryan