Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.6.1 Schema File #1896

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Add 1.6.1 Schema File #1896

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99518c5
Add 1.6.1 Schema File
carlosalberto Aug 27, 2021
b992a98
Restore 1.6.0 to make the build pass.
carlosalberto Aug 27, 2021
6ee9184
Merge branch 'main' into schema_161
carlosalberto Aug 30, 2021
e8b7f71
Merge branch 'main' into schema_161
carlosalberto Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions schemas/1.6.1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
file_format: 1.0.0
schema_url: https://opentelemetry.io/schemas/1.6.1
versions:
1.6.1:
Copy link
Member

@Oberon00 Oberon00 Aug 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, we should have some directive here to map the old enum values to the new ones.
But according to https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md, we only have a rename_attributes transformation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are actually considering 1.6.0 a broken version, but we should not make this the norm, and go the way you described (hopefully @tigrannajaryan can weight here as to what things need to be done). Sounds about right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are actually considering 1.6.0 a broken version

I was OOO, so don't know the details. Can you please tell why is it broken?
If we consider 1.6.0 a version that was never really released then we can skip it in the schema file. However if 1.6.0 was released, but we don't have a way to describe the changes from 1.6.0 to 1.6.1 it is best to still include 1.6.0 in the schema file, but keep the list of transformations empty.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're considering 1.6.0 DOA, but the issue was the original semantic conventions were unable to be generated due to violating semcon standards.

We decided to just mark 1.6.0 DOA because there was no adoption (so far) of 1.6.0, and languages were having trouble adopting those semcon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best to still include 1.6.0 in the schema file, but keep the list of transformations empty

Sounds reasonable to me, what do you think @carlosalberto ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best to still include 1.6.0 in the schema file, but keep the list of transformations empty

@tigrannajaryan would this make sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'd go for keeping it the current way, at least for this rather extraordinary situation, as open-telemetry/opentelemetry.io#695 was already merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way works, no big deal. I don't think anybody has schema files for 1.6.0 in real use.
For the future we can add more automated checks to ensure version list in schema files and version numbers of releases here don't get out of sync.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tigrannajaryan Makes sense!

1.5.0:
1.4.0: