Add 1.6.1 Schema File #1896
Add 1.6.1 Schema File #1896
Conversation
Retire the broken 1.6.0 Schema file too.
| file_format: 1.0.0 | ||
| schema_url: https://opentelemetry.io/schemas/1.6.1 | ||
| versions: | ||
| 1.6.1: |
There was a problem hiding this comment.
Normally, we should have some directive here to map the old enum values to the new ones.
But according to https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md, we only have a rename_attributes transformation.
There was a problem hiding this comment.
We are actually considering 1.6.0 a broken version, but we should not make this the norm, and go the way you described (hopefully @tigrannajaryan can weight here as to what things need to be done). Sounds about right?
There was a problem hiding this comment.
We are actually considering 1.6.0 a broken version
I was OOO, so don't know the details. Can you please tell why is it broken?
If we consider 1.6.0 a version that was never really released then we can skip it in the schema file. However if 1.6.0 was released, but we don't have a way to describe the changes from 1.6.0 to 1.6.1 it is best to still include 1.6.0 in the schema file, but keep the list of transformations empty.
There was a problem hiding this comment.
We're considering 1.6.0 DOA, but the issue was the original semantic conventions were unable to be generated due to violating semcon standards.
We decided to just mark 1.6.0 DOA because there was no adoption (so far) of 1.6.0, and languages were having trouble adopting those semcon.
There was a problem hiding this comment.
best to still include 1.6.0 in the schema file, but keep the list of transformations empty
Sounds reasonable to me, what do you think @carlosalberto ?
There was a problem hiding this comment.
best to still include 1.6.0 in the schema file, but keep the list of transformations empty
@tigrannajaryan would this make sense?
There was a problem hiding this comment.
Actually I'd go for keeping it the current way, at least for this rather extraordinary situation, as open-telemetry/opentelemetry.io#695 was already merged.
There was a problem hiding this comment.
Either way works, no big deal. I don't think anybody has schema files for 1.6.0 in real use.
For the future we can add more automated checks to ensure version list in schema files and version numbers of releases here don't get out of sync.
There was a problem hiding this comment.
@tigrannajaryan Makes sense!
|
We must merge open-telemetry/opentelemetry.io#695 as well in order to publish the schema. |
Related to the recently 1.6.1 Release.
Note: cannot retire the broken 1.6.0 Schema file too, as per the current build.