Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend semantic conventions for RPC #27

Closed
SergeyKanzhelev opened this issue May 24, 2019 · 5 comments · Fixed by #604
Closed

Extend semantic conventions for RPC #27

SergeyKanzhelev opened this issue May 24, 2019 · 5 comments · Fixed by #604
Assignees
@arminru
Labels
area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory
Milestone
v0.6

Comments

@SergeyKanzhelev
Copy link
Member

No description provided.

@SergeyKanzhelev SergeyKanzhelev added this to the SDK complete milestone Jun 3, 2019
@SergeyKanzhelev SergeyKanzhelev added area:sdk Related to the SDK area:semantic-conventions Related to semantic conventions and removed area:sdk Related to the SDK labels Jun 21, 2019
@SergeyKanzhelev SergeyKanzhelev removed this from the SDK proposal complete milestone Jun 21, 2019
@SergeyKanzhelev SergeyKanzhelev added this to the Alpha v0.3 milestone Sep 27, 2019
@Oberon00 Oberon00 mentioned this issue Oct 1, 2019
Closed
@tedsuo
Copy link
Contributor

tedsuo commented Dec 4, 2019

Closing this as it is getting scooped up into the latest semantic convention work

@tedsuo tedsuo closed this as completed Dec 4, 2019
@arminru
Copy link
Member

arminru commented Dec 11, 2019 •
edited
Loading

@SergeyKanzhelev @tedsuo
While this was partially addressed in #349, I do not think that semantic conventions for RPC are complete yet. It would make sense to add the RPC method and flavor/system, for example. As of now the conventions also only specify/allow gRPC. Please reopen.

@jmacd
Copy link
Contributor

jmacd commented Jan 29, 2020

I believe this was fixed by #349 and #386.

@jmacd jmacd closed this as completed Jan 29, 2020
@jmacd jmacd modified the milestones: Alpha v0.3, Alpha v0.4 Jan 29, 2020
@Oberon00
Copy link
Member

I think the last comment by @arminru still applies, we only have conventions for the very narrow special case of grpc. Please reopen again.

@arminru arminru reopened this Apr 3, 2020
@arminru arminru changed the title semantic_convention: remoting server attributes Extend semantic conventions for RPC Apr 3, 2020
@arminru
Copy link
Member

arminru commented Apr 3, 2020

Yet to be done (as already mentioned above):

  • allow RPC systems/frameworks other than gRPC
  • add attribute for the RPC system/framework/flavor being used
  • add the method name so that it doesn't have to be parsed out of the span name and to make it available for sampling decisions since the span name is not reliable to use (remove warnings for trace.UpdateName #506)

@arminru arminru self-assigned this May 5, 2020
@arminru arminru mentioned this issue May 14, 2020
Merged
@carlosalberto carlosalberto modified the milestones: v0.5, v0.6 Jun 9, 2020
@bogdandrutu bogdandrutu added the spec:trace Related to the specification/trace directory label Jun 12, 2020
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
@g-easy
Dockerfile: don't forget install_gcc48.sh (open-telemetry#27)
b3645fc
rockb1017 pushed a commit to rockb1017/opentelemetry-specification that referenced this issue Nov 18, 2021
Rename the Server-Timing property to SPLUNK_TRACE_RESPONSE_HEADER_ENA…
6c78e05 
…BLED

And set its default value to .

Based on discussions: open-telemetry#18, open-telemetry#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arminru arminru

Labels
area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
v0.6
7 participants
@tedsuo @carlosalberto @Oberon00 @bogdandrutu @jmacd @arminru @SergeyKanzhelev