Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify span end behavior: should it close all the children #18

Closed
SergeyKanzhelev opened this issue May 21, 2019 · 1 comment
Closed

Clarify span end behavior: should it close all the children #18

SergeyKanzhelev opened this issue May 21, 2019 · 1 comment
Assignees
@SergeyKanzhelev
Labels
area:api Cross language API specification issue
Milestone
API proposal done

Comments

@SergeyKanzhelev
Copy link
Member

See discussion at open-telemetry/opentelemetry-js#4
@SergeyKanzhelev SergeyKanzhelev added the area:api Cross language API specification issue label May 21, 2019
@SergeyKanzhelev SergeyKanzhelev mentioned this issue May 21, 2019
Closed
@tedsuo
Copy link
Contributor

tedsuo commented May 30, 2019

5/29 Discussion

  • Parents should not automatically close children.
  • This behavior would hide what the child operation is actually doing.

@SergeyKanzhelev SergeyKanzhelev added this to the API complete milestone May 31, 2019
@SergeyKanzhelev SergeyKanzhelev self-assigned this Jun 3, 2019
@SergeyKanzhelev SergeyKanzhelev mentioned this issue Jun 3, 2019
Merged
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
@rnburn
Add windows ci. (open-telemetry#18)
b61d5fb 
* Add windows ci.

* Don't build shared libraries.

* Use dynamic gtest.

* Change target.

* Run cmake tests on windows.

* Invoke tests.
rockb1017 pushed a commit to rockb1017/opentelemetry-specification that referenced this issue Nov 18, 2021
Rename the Server-Timing property to SPLUNK_TRACE_RESPONSE_HEADER_ENA…
6c78e05 
…BLED

And set its default value to .

Based on discussions: open-telemetry#18, open-telemetry#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
area:api Cross language API specification issue
Projects
None yet
Milestone
API proposal done
Development

No branches or pull requests
2 participants
@tedsuo @SergeyKanzhelev