Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics - Instrument Name Validation fixes #2166

Merged
merged 3 commits into from
Oct 2, 2024

remove unwanted constraints

e7c19ba
Select commit
Loading
Failed to load commit list.
Merged

Metrics - Instrument Name Validation fixes #2166

remove unwanted constraints
e7c19ba
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 2, 2024 in 1s

79.0% (-0.2%) compared to ed27611

View this Pull Request on Codecov

79.0% (-0.2%) compared to ed27611

Details

Codecov Report

Attention: Patch coverage is 86.89655% with 38 lines in your changes missing coverage. Please review.

Project coverage is 79.0%. Comparing base (ed27611) to head (e7c19ba).

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/meter.rs 85.3% 33 Missing ⚠️
opentelemetry-sdk/src/metrics/mod.rs 95.0% 3 Missing ⚠️
opentelemetry-sdk/src/metrics/pipeline.rs 50.0% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #2166     +/-   ##
=======================================
- Coverage   79.2%   79.0%   -0.2%     
=======================================
  Files        121     121             
  Lines      20980   20859    -121     
=======================================
- Hits       16625   16490    -135     
- Misses      4355    4369     +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov