Metrics - Instrument Name Validation fixes #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2166 +/- ##
=======================================
- Coverage 79.2% 79.0% -0.2%
=======================================
Files 121 121
Lines 20980 20859 -121
=======================================
- Hits 16625 16490 -135
- Misses 4355 4369 +14 ☔ View full report in Codecov by Sentry. |
|
The biggest learning from this PR is that - I made plenty of silly copy-paste errors, but all of them were nicely caught by the InMemoryExporter based E2E tests. Though we still have opportunities to further improve test coverage, this is already yielding results and hopefully, continue to do so, as we are about to start the next set of major refactor, in the collect/export pipelein! |
utpilla
reviewed
Oct 2, 2024
utpilla
reviewed
Oct 2, 2024
utpilla
reviewed
Oct 2, 2024
utpilla
reviewed
Oct 2, 2024
utpilla
approved these changes
Oct 2, 2024
lalitb
reviewed
Oct 2, 2024
cijothomas
added a commit
to cijothomas/opentelemetry-rust
that referenced
this pull request
Oct 4, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1699
This does not change the name of the APIs or remove any. That'll be coming next.
This PR ensures that NoOpInstruments are returned incase of any instrument configuration errors, instead of promised Panic (which was not implemented anyway).
Removed test only setting of Erroring for validation.
Also does some refactoring to get some code reuse (plenty of remaining opportunities here, just did a minimal one in this PR)
Added unit tests for validations, and also e2e (inmemoryexporter based) to ensure instruments are no-op. (This actually fixed the existing bug that current SDK allowed invalid instrument names to still operate).
In next set of PRs, will proceed with removing try_init, renaming init to build, and better handling of edge cases, along with further refactoring to move common code to helpers.!
Changelog will be added before release covering full changes as part of #1699