Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics API] Update Instrument Provider and remove try_init methods #2227

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Oct 22, 2024

Towards #1699

Changes

  • Update InstrumentProvider trait methods to return the individual instruments instead of a Result
  • Remove try_init methods from the all the instrument builders

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla requested a review from a team as a code owner October 22, 2024 15:43
@utpilla utpilla changed the title Update Instrument Provider Update Instrument Provider and remove try_init methods Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 58.19672% with 51 lines in your changes missing coverage. Please review.

Project coverage is 79.1%. Comparing base (f45e840) to head (b82eaac).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry/src/metrics/mod.rs 0.0% 32 Missing ⚠️
opentelemetry-sdk/src/metrics/meter.rs 77.9% 19 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2227   +/-   ##
=====================================
  Coverage   79.1%   79.1%           
=====================================
  Files        121     121           
  Lines      21184   21171   -13     
=====================================
- Hits       16772   16762   -10     
+ Misses      4412    4409    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

opentelemetry/src/metrics/instruments/mod.rs Show resolved Hide resolved
opentelemetry-sdk/CHANGELOG.md Show resolved Hide resolved
@utpilla utpilla changed the title Update Instrument Provider and remove try_init methods [Metrics API] Update Instrument Provider and remove try_init methods Oct 22, 2024
@cijothomas cijothomas merged commit 8bd529a into open-telemetry:main Oct 23, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants