Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serialization format for LogRecord fields. #1771

Merged
merged 5 commits into from
May 15, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented May 15, 2024

Changes

  • timestamp (u64) should be converted to a string as per proto-json mapping
  • trace_id and span_id (sequence of bytes) should be converted to hex string as per the otlp specs

This is also consistent with SpanData encoding.

This would be eventually tested through #1759.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team May 15, 2024 02:11
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.6%. Comparing base (348ec9e) to head (1e46f50).
Report is 37 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1771     +/-   ##
=======================================
+ Coverage   71.0%   71.6%   +0.6%     
=======================================
  Files        135     136      +1     
  Lines      20751   20857    +106     
=======================================
+ Hits       14746   14951    +205     
+ Misses      6005    5906     -99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 10f99bf into open-telemetry:main May 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants