Integration tests for Logs #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1759 +/- ##
=====================================
Coverage 73.6% 73.6%
=====================================
Files 124 124
Lines 19517 19517
=====================================
+ Hits 14377 14378 +1
+ Misses 5140 5139 -1 ☔ View full report in Codecov by Sentry. |
lalitb
commented
May 16, 2024
| tokio = { version = "1.0", features = ["full"] } | ||
| serde_json = "1" | ||
| testcontainers = "0.15.0" | ||
| # env_logger = "0.11.3" // uncomment if needed for local debugging. |
There was a problem hiding this comment.
This won't be usable further for local debugging. As we can only have one subscriber with log.
lalitb
commented
May 16, 2024
| for path in ["common.v1.KeyValue.value", "logs.v1.LogRecord.body"] { | ||
| builder = builder | ||
| .field_attribute(path, "#[cfg_attr(feature =\"with-serde\", serde(serialize_with = \"crate::proto::serializers::serialize_to_value\", deserialize_with = \"crate::proto::serializers::deserialize_from_value\"))]"); | ||
| } |
There was a problem hiding this comment.
LogRecord::body is AnyValue, and we need a custom serializer/deserializer for it.
There was a problem hiding this comment.
Yep that's a good follow up but not necessary blocking
There was a problem hiding this comment.
Thanks, this has been added to this PR, as was a pre-requisite to serialize/deserialize LogData.
TommyCpp
approved these changes
May 22, 2024
lalitb
added a commit
to lalitb/opentelemetry-rust
that referenced
this pull request
May 23, 2024
Co-authored-by: Zhongyang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is ready for review. It tests the basic use-case of OTLP Log export using default (grpc) exporter, and compare the generated log file, with one stored in the repo.
The changes are inspired (actually shameless copy :) ) from @TommyCpp 's implementation for span's integration tests.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes