Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: refactor Baggage to remove Noop* #800

Merged
merged 3 commits into from
Jun 8, 2021
Merged

fix!: refactor Baggage to remove Noop* #800

merged 3 commits into from
Jun 8, 2021

Conversation

fbogsany
Copy link
Contributor

@fbogsany fbogsany commented Jun 8, 2021

Fixes #789 and #790

@fbogsany fbogsany linked an issue Jun 8, 2021 that may be closed by this pull request
Consider removing the no-op Baggage Manager #790
Closed
ahayworth
ahayworth approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@ahayworth ahayworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suspected typo but otherwise 👍

api/lib/opentelemetry/baggage.rb Outdated Show resolved Hide resolved
@fbogsany fbogsany merged commit a9bcbda into main Jun 8, 2021
@fbogsany fbogsany deleted the refactor-baggage branch June 8, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahayworth ahayworth ahayworth approved these changes

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider removing the no-op Baggage Manager Consider exposing Baggage Manager as functions
2 participants
@fbogsany @ahayworth