Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider exposing Baggage Manager as functions #789

Closed
carlosalberto opened this issue Jun 5, 2021 · 0 comments · Fixed by #800
Closed

Consider exposing Baggage Manager as functions #789

carlosalberto opened this issue Jun 5, 2021 · 0 comments · Fixed by #800
Assignees
Labels
spec-compliance Required for OpenTelemetry spec compliance
Milestone

Comments

@carlosalberto
Copy link

As BaggageManager is not required in other SIGs API (as there won't be specialized implementations, as opposed to traces/metrics), consider removing this class and expose the functionality directly, e.g.

module Baggage
  def build(context:Context) # etc

This is also how these functions are exposed in Python, btw. Not a strong feeling though.

@fbogsany fbogsany added this to the Tracing v1.0 milestone Jun 7, 2021
@fbogsany fbogsany added the spec-compliance Required for OpenTelemetry spec compliance label Jun 7, 2021
@fbogsany fbogsany self-assigned this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-compliance Required for OpenTelemetry spec compliance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants