fix(pg): update versions to be tested (includes drop support for pg 1.2) #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pg 1.2.x does not work under Ruby >= 3.0. * We currently support and test only Ruby >= 3.0.
robbkidd
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
simi,
kaylareopelle and
xuan-cao-swi
as code owners
|
Is this a |
robbkidd
changed the title
Closed
arielvalentin
approved these changes
Aug 8, 2024
Closed
robbkidd
added a commit
that referenced
this pull request
Aug 8, 2024
The existing loop over appraisals for a gem is swallowing any error exits returned by commands within the loop. Resolves #1097. The specific error mentioned in that issue for failure to bundle install pg 1.2 was fixed in #1108. This change fixes the appraisal loop. Fix appraisal loop swallowing errors: * add an explicit exit to the appraisal loop if any command in the chain fails so that the CI step also fails Fix other errors that were being swallowed: * add a workaround for GEM_HOME file permission problems during bundle install * introduced to GitHub runner images sometime early July 2024 * bound which version of Ruby the gruf gem tests are run against * its gemspec includes upper bounds on Ruby versions which cause bundler install to fail under newer Rubies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With thanks to @matthewtusker for raising the issue and helping to resolve!