Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update pg support #1106

Closed
wants to merge 1 commit into from
Closed

fix: Update pg support #1106

wants to merge 1 commit into from

Conversation

matthewtusker
Copy link

Remove pg versions 1.2 and 1.3, add pg versions 1.4 and 1.5

Remove `pg` versions 1.2 and 1.3, add `pg` versions 1.4 and 1.5
Copy link

CLA Not Signed

@arielvalentin
Copy link
Collaborator

@matthewtusker i approved this before seeing you had not signed the easy cla.

Any chance you will be able to do that?

Copy link
Collaborator

@arielvalentin arielvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the Easy CLA

end

# 1.3.0 significantly changed connecting and the handling of connection strings
appraise 'pg-1.3' do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why dropping 1.3?

@xuan-cao-swi
Copy link
Contributor

Also please take look at the Conventional Commits Validation. I think for this one, fix: would be good.

@arielvalentin arielvalentin changed the title Update pg support fix: Update pg support Aug 8, 2024
@robbkidd
Copy link
Member

robbkidd commented Aug 8, 2024

Per @matthewtusker's notice that the CLA signing process will be delayed for him, I've opened a different PR for the pg versions under test change: #1108.

Thank you for your help, Matthew!

@robbkidd robbkidd closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants