-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update pg
support
#1106
fix: Update pg
support
#1106
Conversation
Remove `pg` versions 1.2 and 1.3, add `pg` versions 1.4 and 1.5
|
@matthewtusker i approved this before seeing you had not signed the easy cla. Any chance you will be able to do that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sign the Easy CLA
end | ||
|
||
# 1.3.0 significantly changed connecting and the handling of connection strings | ||
appraise 'pg-1.3' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why dropping 1.3?
Also please take look at the Conventional Commits Validation. I think for this one, |
Per @matthewtusker's notice that the CLA signing process will be delayed for him, I've opened a different PR for the pg versions under test change: #1108. Thank you for your help, Matthew! |
Remove
pg
versions 1.2 and 1.3, addpg
versions 1.4 and 1.5