Add boto instrumentation #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
added
the
instrumentation
codeboten
added
the
needs reviewers
codeboten
suggested changes
May 25, 2020
ext/opentelemetry-ext-boto/src/opentelemetry/ext/boto/__init__.py
Outdated
Show resolved
Hide resolved
| span.set_attribute(key, value) | ||
|
|
||
|
|
||
| def flatten_dict(dict_, sep=".", prefix=""): |
There was a problem hiding this comment.
Looks like this code could be pulled out into a utility
There was a problem hiding this comment.
Hmm, I don't think this code belongs anywhere outside of this package, but if other related instrumentations use it they could import it from here.
ext/opentelemetry-ext-boto/src/opentelemetry/ext/boto/__init__.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-ext-boto/src/opentelemetry/ext/boto/__init__.py
Outdated
Show resolved
Hide resolved
codeboten
approved these changes
May 27, 2020
toumorokoshi
approved these changes
May 28, 2020
ext/opentelemetry-ext-boto/src/opentelemetry/ext/boto/__init__.py
Outdated
Show resolved
Hide resolved
|
|
||
| def truncate_arg_value(value, max_len=1024): | ||
| """Truncate values which are bytes and greater than ``max_len``. | ||
| Useful for parameters like "Body" in ``put_object`` operations. |
There was a problem hiding this comment.
no need to investigate too deeply on this, but how about strings? is it possible for giant payloads to be sent as strings that should also be truncated?
maybe a json payload? but that's probably binary.
ocelotl
force-pushed
the
issue_628
branch
2 times, most recently
from
f5237b6 to
61f6847
Compare
This is necessary because moto does not support 3.4 https://pypi.org/project/moto/
Co-authored-by: alrex <[email protected]>
Co-authored-by: alrex <[email protected]>
Co-authored-by: alrex <[email protected]>
Co-authored-by: alrex <[email protected]>
Co-authored-by: alrex <[email protected]>
Co-authored-by: Yusuke Tsutsumi <[email protected]>
toumorokoshi
pushed a commit
to toumorokoshi/opentelemetry-python
that referenced
this pull request
Jun 5, 2020
sethmaxwl
pushed a commit
to sethmaxwl/opentelemetry-python
that referenced
this pull request
Jun 5, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* docs: add ioredis example * refactor: simplify example * fix: ioredis example * fix: tracerRegistry not tracer * fix: test only with set command * fix: only use Jaeger as backend Signed-off-by: Naseem <[email protected]> Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #628