Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make boto and botocore instrumentations share code #762

Closed
ocelotl opened this issue Jun 1, 2020 · 0 comments · Fixed by #942
Closed

Make boto and botocore instrumentations share code #762

ocelotl opened this issue Jun 1, 2020 · 0 comments · Fixed by #942
Assignees
@ocelotl
Labels
instrumentation Related to the instrumentation of third party libraries or frameworks

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jun 1, 2020

The boto and botocore instrumentations share some code. Once #689 and #665 are merged in master make one depend on the other so that the code is not duplicated.
@ocelotl ocelotl added the instrumentation Related to the instrumentation of third party libraries or frameworks label Jun 1, 2020
@ocelotl ocelotl self-assigned this Jun 1, 2020
@ocelotl ocelotl mentioned this issue Jul 25, 2020
Merged
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22 @dyladan
plugin(grpc): use HttpTextFormat instead of Binary propagator (open-t…
03bf191 
…elemetry#762)

* feat: update HttpTraceContext for gRPC metadata

* keep textformat interface intact

* update the usage based on new implementation

Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
instrumentation Related to the instrumentation of third party libraries or frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move duplicated code to a dependency ocelotl/opentelemetry-python
1 participant
@ocelotl