Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding suppress_instrumentation in Metrics #529

Merged

Conversation

hectorhdzg
Copy link
Member

Fixes #524

@hectorhdzg hectorhdzg requested a review from a team March 25, 2020 23:25
@codecov-io
Copy link

codecov-io commented Mar 26, 2020

Codecov Report

Merging #529 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
+ Coverage   89.47%   89.63%   +0.15%     
==========================================
  Files          43       43              
  Lines        2214     2218       +4     
  Branches      250      250              
==========================================
+ Hits         1981     1988       +7     
+ Misses        161      158       -3     
  Partials       72       72              
Impacted Files Coverage Δ
...src/opentelemetry/sdk/metrics/export/controller.py 86.66% <100.00%> (+12.59%) ⬆️
...emetry-sdk/src/opentelemetry/sdk/trace/__init__.py 92.51% <0.00%> (ø)
...opentelemetry/sdk/context/propagation/b3_format.py 87.27% <0.00%> (ø)
...ry/trace/propagation/tracecontexthttptextformat.py 84.28% <0.00%> (ø)
...ntelemetry-api/src/opentelemetry/trace/__init__.py 83.12% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39654a0...cc58b08. Read the comment docs.

Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks for adding this.

@toumorokoshi toumorokoshi merged commit ac56d0e into open-telemetry:master Apr 1, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add suppress_instrumentation flag in context for Metrics
4 participants