Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suppress_instrumentation flag in context for Metrics #524

Closed
hectorhdzg opened this issue Mar 24, 2020 · 2 comments · Fixed by #529
Closed

Add suppress_instrumentation flag in context for Metrics #524

hectorhdzg opened this issue Mar 24, 2020 · 2 comments · Fixed by #529
Assignees
@hectorhdzg

Comments

@hectorhdzg
Copy link
Member

Similar to logic in SpanProcessors, this need to be done in Metrics to avoid duplicated telemetry when using Http ext or other packages relying on this
@hectorhdzg hectorhdzg mentioned this issue Mar 24, 2020
Merged
@lzchen
Copy link
Contributor

lzchen commented Mar 24, 2020

Curious as to how we are going to handle the case of when dependency calls being made at the same time export is being called. With this logic, calls during when suppress_instrumentation flag is true (during export) will not be tracked.

@hectorhdzg hectorhdzg self-assigned this Mar 25, 2020
@lzchen
Copy link
Contributor

lzchen commented Mar 25, 2020

EDIT: It seems like context is local per thread so that use case won't be an issue.

@hectorhdzg hectorhdzg mentioned this issue Mar 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hectorhdzg hectorhdzg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding suppress_instrumentation in Metrics hectorhdzg/opentelemetry-python
2 participants
@lzchen @hectorhdzg