Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed references to [test] packages from eachdist #3947

Merged
merged 8 commits into from
Jun 5, 2024
Merged

removed references to [test] packages from eachdist #3947

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e2f2df4
removed refereces from test packages from eachdist
soumyadeepm04 Jun 3, 2024
66573e0
modified changelog
soumyadeepm04 Jun 4, 2024
f49b2d5
reverted CHANGELOG and further changed eachdist
soumyadeepm04 Jun 4, 2024
70c55f6
restored execute args
soumyadeepm04 Jun 4, 2024
8b52d42
restored execute args
soumyadeepm04 Jun 4, 2024
994b42d
restored execute args
soumyadeepm04 Jun 4, 2024
f68d49e
fix lint test
soumyadeepm04 Jun 4, 2024
3e0feec
Merge branch 'main' into feature
lzchen Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions scripts/eachdist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ def setup_instparser(instparser):

setup_instparser(instparser)
instparser.add_argument("--editable", "-e", action="store_true")
instparser.add_argument("--with-test-deps", action="store_true")
instparser.add_argument("--with-dev-deps", action="store_true")
instparser.add_argument("--eager-upgrades", action="store_true")

Expand All @@ -208,7 +207,6 @@ def setup_instparser(instparser):
editable=True,
with_dev_deps=True,
eager_upgrades=True,
with_test_deps=True,
)

lintparser = subparsers.add_parser(
Expand Down Expand Up @@ -466,28 +464,6 @@ def install_args(args):
check=True,
)

allfmt = "-e 'file://{}" if args.editable else "'file://{}"
# packages should provide an extra_requires that is named
# 'test', to denote test dependencies.
extras = []
if args.with_test_deps:
soumyadeepm04 marked this conversation as resolved.
Show resolved Hide resolved
extras.append("test")
if extras:
allfmt += f"[{','.join(extras)}]"
# note the trailing single quote, to close the quote opened above.
allfmt += "'"

execute_args(
soumyadeepm04 marked this conversation as resolved.
Show resolved Hide resolved
parse_subargs(
args,
(
"exec",
"python -m pip install {} " + join_args(args.pipargs),
"--all",
allfmt,
),
)
)
if args.with_dev_deps:
rootpath = find_projectroot()
runsubprocess(
Expand Down