Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed references to [test] packages from eachdist #3947

Merged
merged 8 commits into from
Jun 5, 2024

Conversation

soumyadeepm04
Copy link
Contributor

@soumyadeepm04 soumyadeepm04 commented Jun 4, 2024

Description

Removed references to [test] packages from eachdist.py script. Fixes issue #3903.

Fixes #3903

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Ran tox -e py311-opentelemetry-sdk locally

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes.

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@soumyadeepm04 soumyadeepm04 requested a review from a team June 4, 2024 05:56
Copy link

linux-foundation-easycla bot commented Jun 4, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@soumyadeepm04 soumyadeepm04 changed the title removed refereces from test packages from eachdist removed references to [test] packages from eachdist Jun 4, 2024
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 4, 2024
@soumyadeepm04 soumyadeepm04 requested a review from xrmx June 4, 2024 14:53
@soumyadeepm04 soumyadeepm04 requested a review from pmcollins June 4, 2024 15:41
@pmcollins
Copy link
Member

Thanks -- I ran this change locally and it works fine for me.

Maybe someone else can weigh in here but I believe there are extra steps necessary because this file is mostly copied in contrib and so I believe this change will have to be manually applied there as well.

I'm going to open an issue to consolidate the eachdist logic between core and contrib.

@soumyadeepm04
Copy link
Contributor Author

soumyadeepm04 commented Jun 4, 2024

Had a couple formatting and whitespace issues after the last change, fixed it in the new commit. The lint test should pass now. Thanks for your time.

Copy link
Member

@pmcollins pmcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Can you also apply it to contrib?

@soumyadeepm04
Copy link
Contributor Author

Sure, would I have to create an issue there first before creating a PR?

@pmcollins
Copy link
Member

Sure, would I have to create an issue there first before creating a PR?

I think a reference to this PR's issue is fine for now.

@lzchen lzchen merged commit 762bd8f into open-telemetry:main Jun 5, 2024
233 checks passed
@soumyadeepm04 soumyadeepm04 deleted the feature branch June 5, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove references to [test] extras from eachdist script
4 participants