Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict version of protobuf for Jaeger exporter #3502

Closed
wants to merge 1 commit into from
Closed

Restrict version of protobuf for Jaeger exporter #3502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions exporter/opentelemetry-exporter-jaeger-proto-grpc/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ classifiers = [
"Typing :: Typed",
]
dependencies = [
"protobuf ~= 3.20.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause a conflict with packages/applications trying to install newer protobuf 4. Similar to #3074

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but we are out of support for this exporter already. Maybe we should consider removing it from our tests?

"googleapis-common-protos ~= 1.52, < 1.60.0",
"grpcio >= 1.0.0, < 2.0.0",
"opentelemetry-api ~= 1.3",
Expand Down
Loading