Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping support for protobuf 3 in opentelemetry-proto #3074

Closed
aabmass opened this issue Dec 3, 2022 · 7 comments
Closed

Consider dropping support for protobuf 3 in opentelemetry-proto #3074

aabmass opened this issue Dec 3, 2022 · 7 comments
Labels
discussion Issue or PR that needs/is extended discussion. priority:p2 Issues that are less important than priority:p1 proto

Comments

@aabmass
Copy link
Member

aabmass commented Dec 3, 2022

In #3070, we widened the supported version of protobuf to protobuf>=3.19, < 5.0 based on votes and discussion in #2880 (comment) and #3050

Long term, newer versions of protoc will not generate code that is compatible with older versions of protobuf library (see protocolbuffers/protobuf#11123 (comment)), meaning it will be hard to support both protobuf 3.x and 4.x. There are possible workarounds for this like

  • generating code for both versions and choosing the correct one at runtime
  • maintaining two major versions of opentelemetry-proto and making releases against both major versions with separate protoc compilers.

The alternative is to drop support for protobuf 3 altogether at some reasonable point in the future, say 6 months.

@aabmass aabmass added discussion Issue or PR that needs/is extended discussion. priority:p2 Issues that are less important than priority:p1 proto labels Dec 3, 2022
@iwedaz
Copy link

iwedaz commented Jan 13, 2023

@ocelotl
Copy link
Contributor

ocelotl commented May 24, 2023

@aabmass six months have passed, I think it is a good time to consider dropping support for protobuf 3

@daxartio
Copy link

Why should we drop support for protobuf 3? Maybe just add support for protobuf 4 in this package opentelemetry-exporter-zipkin-proto-http?

@aabmass
Copy link
Member Author

aabmass commented Jun 15, 2023

@daxartio this issue was specifically regarding the opentelemetry-proto. The reason to drop protobuf 3 is so we can upgrade the version of protoc we use to generate the protobufs (newer versions of protoc don't work with protobuf 3 runtime library). If there is a separate issue with zipkin exporter, would you mind creating an issue for it?

@daxartio
Copy link

I don't mind that protobuf 3 will be dropped. But now i cannot use protobuf 4 because in the dependencies are written "protobuf ~= 3.12"

@aabmass
Copy link
Member Author

aabmass commented Jun 22, 2023

@daxartio if you are specifically talking about the zipkin exporter, can you please create a separate issue for that. I agree that it is a problem.

@emdneto
Copy link
Member

emdneto commented Oct 14, 2024

Closing as support for protobuf5 was merged (which drop support for protobuf 3 and 4) 🚀 #4206

@emdneto emdneto closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Issue or PR that needs/is extended discussion. priority:p2 Issues that are less important than priority:p1 proto
Projects
None yet
Development

No branches or pull requests

5 participants