Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate contrib jobs per instrumentation #3500

Closed
wants to merge 4 commits into from
Closed

Separate contrib jobs per instrumentation #3500

wants to merge 4 commits into from

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Nov 3, 2023 •
edited
Loading

Fixes #3499

@ocelotl ocelotl self-assigned this Nov 3, 2023
@ocelotl ocelotl requested a review from a team November 3, 2023 02:29
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 3, 2023
@ocelotl ocelotl mentioned this pull request Nov 3, 2023
Closed
@lzchen
Copy link
Contributor

lzchen commented Nov 3, 2023

What's the reasoning behind this change?

@ocelotl
Copy link
Contributor Author

ocelotl commented Nov 3, 2023

What's the reasoning behind this change?

Updated the description, see #3499 please.

aabmass
aabmass approved these changes Nov 3, 2023
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@ocelotl ocelotl closed this Nov 3, 2023
@ocelotl
Copy link
Contributor Author

ocelotl commented Nov 3, 2023

Closing this PR for the time being to evaluate if the amount of jobs would impact the organization or not.

@ocelotl
Copy link
Contributor Author

ocelotl commented Nov 3, 2023

@trask this is the PR I was referring to

@ocelotl
Copy link
Contributor Author

ocelotl commented Nov 3, 2023

We just merged a PR, which executed 110 jobs: https://github.com/open-telemetry/opentelemetry-python/pull/3496/checks

@ocelotl
Copy link
Contributor Author

ocelotl commented Nov 3, 2023 •
edited
Loading

Reopening to check the amount of jobs this would create.

This change should turn 84 jobs (7 packages * 6 Python versions * 2 OS versions) into 252 (21 packages * 6 Python versions * 2 OS versions) for an increase of 252 - 84 = 168 jobs.

This change should turn 2 jobs into 48 (since these jobs are only run in one Pyhton version and one OS version) for an increase of 48 - 2 = 46 jobs.

The total increase in jobs would be 168 + 46 = 214 jobs if I'm not totally wrong.

@ocelotl ocelotl reopened this Nov 3, 2023
@ocelotl
Copy link
Contributor Author

ocelotl commented Nov 3, 2023

This seems to be completely stuck, I worry this may be affecting other runs, closing this PR for the time being.

@ocelotl ocelotl closed this Nov 3, 2023
@trask
Copy link
Member

trask commented Nov 3, 2023

This seems to be completely stuck

I think it's because https://github.com/open-telemetry/opentelemetry-python/actions/runs/6749875017:

Invalid workflow file: .github/workflows/test.yml#L37
You have an error in your yaml syntax on line 37

@ocelotl ocelotl mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate contrib jobs per instrumentation
4 participants
@ocelotl @lzchen @trask @aabmass