Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate contrib jobs per instrumentation #3499

Closed
ocelotl opened this issue Nov 3, 2023 · 2 comments
Closed

Separate contrib jobs per instrumentation #3499

ocelotl opened this issue Nov 3, 2023 · 2 comments
Assignees
Labels

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Nov 3, 2023

Every contrib instrumentation is run in the same job, which produces logfiles which are extremely long and hard to debug. Also, if one of the runs fails and we want to run it again, it means running the entire job which is very slow. Separate the instrumentation job into multiple jobs, one per instrumentation.

@ocelotl ocelotl added the tests label Nov 3, 2023
@ocelotl ocelotl self-assigned this Nov 3, 2023
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Nov 3, 2023
@aabmass
Copy link
Member

aabmass commented Nov 3, 2023

Will this have any negative impact on Github actions quota? IIUC this will run more small jobs which each get queued separately

ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Nov 3, 2023
@ocelotl
Copy link
Contributor Author

ocelotl commented Nov 3, 2023

Will this have any negative impact on Github actions quota? IIUC this will run more small jobs which each get queued separately

Well, aparently the quota is not measured in jobs but in minutes, and since this is simply splitting a long job into smaller ones, I don't think it would increase substantially the amount of minutes considering overhead should be small.

The maximum amount of jobs depends on the account type. I'll reach out to the organization managers to check if we can make this change without impacting the organization.

ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Nov 3, 2023
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Nov 23, 2023
@ocelotl ocelotl closed this as completed in 975733c Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants