Revert "Enabled custom sampler configuration via env vars (#2972)" #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etry#2972)" This reverts commit 35ba257.
jeremydvoss
force-pushed
the
revert-sampler
branch
from
c14add0 to
965a2fe
Compare
srikanthccv
added
the
Approve Public API check
srikanthccv
approved these changes
Nov 3, 2022
|
Since the feature already made it to the release. I'm instead going to work on a refactor to mitigate the issue rather than reverting and unreverting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverting #2972 as a temporary solution for #3013. Since a release is impending, I propose removing this feature until a fix is found since it may involve a slightly different interface and documentation.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
No
Checklist: