Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Sampler injection can cause a runtime circular dependency in certain situations. #3013

Closed
jeremydvoss opened this issue Nov 2, 2022 · 1 comment · Fixed by #3026
Closed
Labels
bug Something isn't working

Comments

@jeremydvoss
Copy link
Contributor

Describe your environment
Version 3.10.7
While the custom sampler injection code worked for unit testing and some manual testing. I have discovered a bug that can easily occur.

PR that caused issue: #2972

Steps to reproduce
Describe exactly how to reproduce the error. Include a code sample if applicable.

What is the expected behavior?
What did you expect to see?

What is the actual behavior?
What did you see instead?

Additional context
Add any other context about the problem here.

@ocelotl
Copy link
Contributor

ocelotl commented Nov 17, 2022

@jeremydvoss please add the information that describes this issue here (I think it is now in the description of #3032).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants