Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented better backoff version checking and added unit test #3010

Closed

Conversation

Buduzz
Copy link

@Buduzz Buduzz commented Nov 1, 2022

Description

Implemented better backoff version checking and added unit test

Fixes #3006

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Added unit test

-- [x] Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@Buduzz Buduzz requested a review from a team November 1, 2022 14:06
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 1, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@Buduzz
Copy link
Author

Buduzz commented Nov 1, 2022

Hello @srikanthccv Please take a look

@Buduzz
Copy link
Author

Buduzz commented Nov 1, 2022

hi @ocelotl @lzchen please take a look

@srikanthccv
Copy link
Member

@Buduzz, as mentioned in the issue comment, this is not the correct fix. Meanwhile, I am converting this to a draft. Mark it ready when you implement the suggestion from the issue.

@srikanthccv srikanthccv marked this pull request as draft November 8, 2022 02:57
@srikanthccv
Copy link
Member

Are you still working on this?

@srikanthccv
Copy link
Member

@Buduzz are you still working on this?

@srikanthccv
Copy link
Member

Re-open if you get to work on this again. This is also not the right approach.

@srikanthccv srikanthccv closed this Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better version checking for backoff package in OTLP exporters
2 participants