-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better version checking for backoff package in OTLP exporters #3006
Comments
Hi @srikanthccv |
@Buduzz Looking at the pull request changes, I don't think you understood the issue. What is needed is the removal of this logic (in all other places), which tries to infer the version by checking the code behavior and introduce the conditional logic by checking the |
@srikanthccv thank you, I'll make the adjustments and revert |
I'll just note here that In [1]: from importlib.metadata import version
In [2]: version('backoff')
Out[2]: '1.0' In [1]: from importlib.metadata import version
In [2]: version('backoff')
Out[2]: '2.2.1' You will likely still need a |
Is this issue resolved? I am looking for a "good first issue" as I have never contributed to open source before. |
This is not resolved yet, but there is already one PR attempting to address it, so I suggest you pick another good-first-issue. |
Is this not why the backport of Side note: |
@srikanthccv if this issue is still open I would like to work on it? |
This is a better way to check for a package version number:
Originally posted by @ocelotl in #2980 (comment)
The text was updated successfully, but these errors were encountered: