-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry-exporter-prometheus
: restore package
#2321
opentelemetry-exporter-prometheus
: restore package
#2321
Conversation
1f636d7
to
aad4633
Compare
The Prometheus exporter was moved into the `metrics` branch prior to releasing 1.0 for tracing. Now that the metrics API and SDK are further along, we can bring back the exporter and update it to use the new methods. The original code for this PR comes from https://github.com/open-telemetry/opentelemetry-python/tree/metrics/exporter/opentelemetry-exporter-prometheus
36f0a4f
to
0ef40d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some initial review comments
exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Srikanth Chekuri <[email protected]>
exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/export/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/export/__init__.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Diego Hurtado <[email protected]> Co-authored-by: Nathaniel Ruiz Nowell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many moving parts here with latest changes. @codeboten would you mind adding some ascii diagram of the pipeline? that would really help me to get the better idea of whole thing.
One question I have is if there are multiple exporter configured ex (otlp, prometheus), is there a chance of discrepancies in metric output because of different collection cycles? each metric reader has separate state so this shouldn't be a problem.
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/export/__init__.py
Outdated
Show resolved
Hide resolved
@srikanthccv Sure here's an attempt, please take a look:
|
simplified the implementation to remove unnecessary interfaces.
@srikanthccv @aabmass @ocelotl please take a look at the latest change, i've removed the added interfaces, which i think makes it a lot cleaner on the implementation side... still undecided if this makes things better for the users though. |
Description
The Prometheus exporter was moved into the
metrics
branch prior to releasing 1.0 for tracing. Now that the metrics API and SDK are further along, we can bring back the exporter and update it to use the new methods. The original code for this PR comes from https://github.com/open-telemetry/opentelemetry-python/tree/metrics/exporter/opentelemetry-exporter-prometheusFixes #2291