Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prometheus-exporter] list attributes should be json encoded #2502

Closed
codeboten opened this issue Mar 4, 2022 · 1 comment
Closed

[prometheus-exporter] list attributes should be json encoded #2502

codeboten opened this issue Mar 4, 2022 · 1 comment
Labels
1.10.0rc1 release candidate 1 for metrics GA good first issue Good first issue help wanted metrics

Comments

@codeboten
Copy link
Contributor

A followup to the discussion in #2321:

Based on the attribute specification, it looks like the list should just be converted to its JSON representation.

Originally posted by @codeboten in #2321 (comment)
@codeboten codeboten mentioned this issue Mar 4, 2022
Merged
Arvind2222 added a commit to Arvind2222/opentelemetry-python that referenced this issue Apr 7, 2022
@Arvind2222
JSON Convert Values for prometheus collector
8f853af 
* Fixes open-telemetry#2502
@Arvind2222 Arvind2222 mentioned this issue Apr 7, 2022
Closed
8 tasks
Arvind2222 added a commit to Arvind2222/opentelemetry-python that referenced this issue Apr 7, 2022
@Arvind2222
JSON Convert Values for prometheus collector
4883455 
* Fixes open-telemetry#2502
@ocelotl ocelotl added the 1.10.0rc1 release candidate 1 for metrics GA label Apr 21, 2022
ocelotl pushed a commit to ocelotl/opentelemetry-python that referenced this issue Apr 26, 2022
@Arvind2222 @ocelotl
JSON Convert Values for prometheus collector * Fixes open-telemetry#2502
0337289
@ocelotl
Copy link
Contributor

ocelotl commented Apr 26, 2022

Fixed in #2642

@ocelotl ocelotl closed this as completed Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.10.0rc1 release candidate 1 for metrics GA good first issue Good first issue help wanted metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert Values to JSON for prometheus collector Arvind2222/opentelemetry-python
2 participants
@codeboten @ocelotl