-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding readable span #1560
adding readable span #1560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
self.parent = parent | ||
self._name = name | ||
self._context = context | ||
self._parent = parent | ||
self.sampler = sampler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we lock down sampler, traceconfig and span_processor?
As discussed with @codeboten , not certain yet if the current PR adds much value if we don't prevent the "writeable" property on the span when passed into the spanprocessor. |
Span now returns a |
Description
This PR adds
ReadableSpan
to provide read-only access to attributes of a SpanFixes #1001
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?
Checklist: