Update span interface usage #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
requested review from
a team,
ocelotl and
hectorhdzg
and removed request for
a team
added 2 commits
February 8, 2021 21:01
added 2 commits
February 9, 2021 09:55
lzchen
approved these changes
Feb 9, 2021
lzchen
pushed a commit
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per PR open-telemetry/opentelemetry-python#1560, attributes return a MappingProxy, updating the botocore tests to prevent them from writing the attributes.
Also per that PR, the sampler is not exposed through the ReadableSpan interface, updating the datadog exporter to use the sampler set in the tracer_provider instead.