Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zipkin exporter status code and error tag #1486

Merged
merged 11 commits into from
Dec 23, 2020
Merged

Update zipkin exporter status code and error tag #1486

merged 11 commits into from
Dec 23, 2020
+24 −26

Conversation

srikanthccv
Copy link
Member

Fixes #1475

@srikanthccv srikanthccv requested review from a team, toumorokoshi and lzchen and removed request for a team December 16, 2020 14:57
toumorokoshi
toumorokoshi approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

codeboten
codeboten approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@codeboten codeboten merged commit 4195360 into open-telemetry:master Dec 23, 2020
@srikanthccv srikanthccv deleted the zipkin-status branch September 24, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@toumorokoshi toumorokoshi toumorokoshi approved these changes

@codeboten codeboten codeboten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Zipkin status code and error tag
4 participants
@srikanthccv @codeboten @toumorokoshi @lzchen