Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Zipkin status code and error tag #1475

Closed
lzchen opened this issue Dec 14, 2020 · 1 comment · Fixed by #1486
Closed

Update Zipkin status code and error tag #1475

lzchen opened this issue Dec 14, 2020 · 1 comment · Fixed by #1486
Assignees
@srikanthccv
Labels
exporters good first issue Good first issue release:required-for-ga To be resolved before GA release

Comments

@lzchen
Copy link
Contributor

lzchen commented Dec 14, 2020

From the specs, Zipkin exporter exported tag for status code should be string representation.

Also, needs an error tag for if status is error.
@lzchen lzchen added bug Something isn't working exporters release:required-for-ga To be resolved before GA release good first issue Good first issue and removed bug Something isn't working labels Dec 14, 2020
@srikanthccv
Copy link
Member

Assign this to me.

@srikanthccv srikanthccv mentioned this issue Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanthccv srikanthccv

Labels
exporters good first issue Good first issue release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update zipkin exporter status code and error tag srikanthccv/opentelemetry-python
2 participants
@lzchen @srikanthccv