Fix syntax for Docs Build Workflow #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
requested review from
a team,
owais and
aabmass
and removed request for
a team
ocelotl
approved these changes
Nov 18, 2020
owais
approved these changes
Nov 18, 2020
codeboten
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #1371
I had a syntax error in my YAML which meant the docs build still didn't work. Further, I realized it's better and simpler to put the docs dependencies in the
docs-requirements.txtfile, so I've moved it out of tox and into there.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
To fully test it this time, I temporarily disable the "only on push to
master" condition and saw that the build succeeded on my fork.It only failed on the publish command as expected. See the run here: https://github.com/NathanielRN/opentelemetry-python/runs/1420741830?check_suite_focus=true
Checklist: