Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contrib repo checkout for docs build #1371

Merged
merged 3 commits into from
Nov 16, 2020

Conversation

NathanielRN
Copy link
Contributor

Description

This fixes the issue with the docs build which is failing because the Contrib repo is not checked out as part of the docs.yml workflow.

The failure can be seen here: https://github.com/open-telemetry/opentelemetry-python/runs/1379941084

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

No tests, but the errors logs say it's because the opentelemetry-python-contrib repo directory does not exist which makes sense.

Checklist:

  • Followed the style guidelines of this project
    - [ ] Changelogs have been updated
    - [ ] Unit tests have been added
    - [ ] Documentation has been updated

@NathanielRN NathanielRN requested review from a team, codeboten and lzchen and removed request for a team November 10, 2020 22:47
@NathanielRN NathanielRN changed the title Add Contirb repo checkout for docs build Add Contrib repo checkout for docs build Nov 11, 2020
@lzchen
Copy link
Contributor

lzchen commented Nov 11, 2020

Curious as to how the docs build was working before?

@NathanielRN
Copy link
Contributor Author

@lzchen I think it is because we never triggered the workflow run conditions in docs.yml until recently, when a commit was pushed to master that affected a certain path used by docs.

See:

on:
push:
branches:
- master
paths:
- 'docs/**'
- 'exporter/**'
- 'instrumentation/**'
- 'opentelemetry-python/opentelemetry-api/src/opentelemetry/**'
- 'opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/**'

@codeboten codeboten merged commit 1d03c34 into open-telemetry:master Nov 16, 2020
@NathanielRN NathanielRN deleted the fix-docs-push branch November 25, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants